From: H.G. Muller <h.g.muller@hccnet.nl>
Date: Thu, 9 Feb 2012 11:51:25 +0000 (+0100)
Subject: Fix bug in WB combobox readout
X-Git-Url: http://winboard.nl/cgi-bin?a=commitdiff_plain;h=0096ce3333a0828ba3821301db0ee0fb98e671d9;p=xboard.git

Fix bug in WB combobox readout

The previous patch exposed a latent bug in the readout of the generic popup.
---

diff --git a/winboard/wsettings.c b/winboard/wsettings.c
index 10bb427..5098d54 100644
--- a/winboard/wsettings.c
+++ b/winboard/wsettings.c
@@ -387,7 +387,7 @@ GetOptionValues(HWND hDlg, ChessProgramState *cps, Option *optionList)
 		if(!success) break;
 		new = -1;
 		for(k=0; k<optionList[j].max; k++) {
-		    if(!strcmp(choices[k], newText)) new = k;
+		    if(choices[k] && !strcmp(choices[k], newText)) new = k;
 		}
 		if(!cps && new > 0) {
 		    if(*(char**)optionList[j].target) free(*(char**)optionList[j].target);