From: H.G. Muller <h.g.muller@hccnet.nl>
Date: Mon, 2 May 2011 22:24:10 +0000 (+0200)
Subject: Lift length-limit on text-edits in WB generic popup
X-Git-Url: http://winboard.nl/cgi-bin?a=commitdiff_plain;h=341ba470f01b01edda5edef75d92c4497b6d3936;p=xboard.git

Lift length-limit on text-edits in WB generic popup
---

diff --git a/winboard/wsettings.c b/winboard/wsettings.c
index 86a9417..e3ddead 100644
--- a/winboard/wsettings.c
+++ b/winboard/wsettings.c
@@ -326,8 +326,8 @@ GetOptionValues(HWND hDlg, ChessProgramState *cps, Option *optionList)
 // read out all controls, and if value is altered, remember it and send it to the engine
 {
     HANDLE hwndCombo;
-    int i, k, new=0, changed=0;
-    char **choices, newText[MSG_SIZ], buf[MSG_SIZ];
+    int i, k, new=0, changed=0, len;
+    char **choices, newText[MSG_SIZ], buf[MSG_SIZ], *text;
     BOOL success;
 
     for(i=0; i<layout; i++) {
@@ -346,11 +346,15 @@ GetOptionValues(HWND hDlg, ChessProgramState *cps, Option *optionList)
 	    case TextBox:
 	    case FileName:
 	    case PathName:
-		success = GetDlgItemText( hDlg, 2001+2*i, newText, MSG_SIZ - strlen(optionList[j].name) - 9 );
+		if(cps) len = MSG_SIZ - strlen(optionList[j].name) - 9, text = newText;
+		else    len = GetWindowTextLength(GetDlgItem(hDlg, 2001+2*i)) + 1, text = (char*) malloc(len);
+		success = GetDlgItemText( hDlg, 2001+2*i, text, len );
 		if(!success) break;
 		if(!cps) {
+		    char *p;
 		    if(*(char**)optionList[j].target) free(*(char**)optionList[j].target);
-		    *(char**)optionList[j].target = strdup(newText);
+		    *(char**)optionList[j].target = p = text;
+		    while(*p++ = *text++) if(p[-1] == '\r') p--; // crush CR
 		    break;
 		}
 		changed = strcmp(optionList[j].textValue, newText) != 0;