From: Marco Costalba <mcostalba@gmail.com>
Date: Sat, 23 Feb 2013 18:27:32 +0000 (+0100)
Subject: Avoid a tricky line in shelter_storm()
X-Git-Url: http://winboard.nl/cgi-bin?a=commitdiff_plain;h=dbd28bc7f8a92ef06974d37ede2db07922712ae9;p=fairystockfish.git

Avoid a tricky line in shelter_storm()

kf = (kf == FILE_A) ? kf++ : ....

is tricky becuase kf is updated twice and it happens
to do the right thing just by accident.

Rewrite in a better way.

Spotted by pdimov

No functional change.
---

diff --git a/src/pawns.cpp b/src/pawns.cpp
index fca33f2..c1a9316 100644
--- a/src/pawns.cpp
+++ b/src/pawns.cpp
@@ -231,7 +231,7 @@ Value Entry::shelter_storm(const Position& pos, Square ksq) {
   Rank rkUs, rkThem;
   File kf = file_of(ksq);
 
-  kf = (kf == FILE_A) ? kf++ : (kf == FILE_H) ? kf-- : kf;
+  kf = (kf == FILE_A) ? FILE_B : (kf == FILE_H) ? FILE_G : kf;
 
   for (int f = kf - 1; f <= kf + 1; f++)
   {