From: H.G. Muller <h.g.muller@hccnet.nl>
Date: Fri, 27 Dec 2013 19:29:26 +0000 (+0100)
Subject: Fix WB New Variant dialog
X-Git-Url: http://winboard.nl/cgi-bin?p=xboard.git;a=commitdiff_plain;h=165dd54f68ac49be0b50c3d2e1c5c054decdc5ac

Fix WB New Variant dialog

After selecting an engine-defined variant, all radio buttons would refer to
the already selected variant, and thus all appear active, but do nothing.
---

diff --git a/winboard/woptions.c b/winboard/woptions.c
index d3dba20..a4d3ff2 100644
--- a/winboard/woptions.c
+++ b/winboard/woptions.c
@@ -871,12 +871,12 @@ VariantClass
 VariantWhichRadio(HWND hDlg)
 {
   int i=0, j;
+  *engineVariant = NULLCHAR;
   while((j = radioButton[i++]) != -2) {
 	if(j == -1) continue; // no menu button
 	if(IsDlgButtonChecked(hDlg, j) &&
 	   (appData.noChessProgram || strstr(first.variants, VariantName(i-1)))) return (VariantClass) i-1;
   }
-  *engineVariant = NULLCHAR;
   for(i=0; i<9; i++) { // check for engine-defined variants
     if(IsDlgButtonChecked(hDlg, OPT_EngineVariant+i) ) {
 	GetDlgItemText(hDlg, OPT_EngineVariant+i, engineVariant, MSG_SIZ); // remember name, so we can resolve it later
@@ -889,12 +889,15 @@ VariantWhichRadio(HWND hDlg)
 void
 VariantShowRadio(HWND hDlg)
 {
+  char c = *engineVariant;
   int i=0, j;
   CheckDlgButton(hDlg, radioButton[gameInfo.variant], TRUE);
+  *engineVariant = NULLCHAR; // [HGM] kludge to prevent VariantName will always return engineVariant
   while((j = radioButton[i++]) != -2) {
 	if(j == -1) continue; // no menu button
 	EnableWindow(GetDlgItem(hDlg, j), appData.noChessProgram || strstr(first.variants, VariantName(i-1)));
   }
+  *engineVariant = c;
   for(i=0; i<9; i++) { // initialize engine-defined variants
     char *v = EngineDefinedVariant(&first, i); // get name of #i
     if(v) { // there is such a variant