From: H.G.Muller Date: Sat, 12 Mar 2016 13:33:05 +0000 (+0100) Subject: Suppress empty label at top of Edit Tags dialog X-Git-Url: http://winboard.nl/cgi-bin?p=xboard.git;a=commitdiff_plain;h=476926444bc43c8de2ec2fcf9da505050daf70cc Suppress empty label at top of Edit Tags dialog There is a Label Option above the text memo of the Edit Tags dialog that can display a message, but it is only used in cmail mode, and is passed as a NULL pointer otherwise. (On which GenericPopup then crashed when it wanted to attach a help click.) Now we simply suppress display of that widget when there is no message. --- diff --git a/dialogs.c b/dialogs.c index d57b576..084d9f4 100644 --- a/dialogs.c +++ b/dialogs.c @@ -1259,7 +1259,7 @@ NewTagsPopup (char *text, char *msg, char *ttl) if(tagsText) free(tagsText); tagsText = strdup(text); tagsOptions[0].name = msg; MarkMenu("View.Tags", TagsDlg); - GenericPopUp(tagsOptions, title, TagsDlg, BoardWindow, NONMODAL, appData.topLevel); + GenericPopUp(tagsOptions + (msg == NULL), title, TagsDlg, BoardWindow, NONMODAL, appData.topLevel); } void