H.G. Muller [Thu, 29 Dec 2011 14:32:20 +0000]
Fix parsing of faulty PGN tags
A closing bracket could be missed in a malformed tag
H.G. Muller [Thu, 29 Dec 2011 14:29:00 +0000]
Fix parser for variant seirawan
The new parser didnot understand gating suffixes with /, and did not
allow any suffix at all on SAN castling moves.
H.G. Muller [Wed, 28 Dec 2011 21:32:38 +0000]
Try to not confuse ICS rating adustments as shouts
An explicit pattern match for the rating adjustment is added before
matching the shouts.
H.G. Muller [Wed, 28 Dec 2011 21:21:54 +0000]
Describe -overrideLineGap option in texi file
H.G. Muller [Wed, 28 Dec 2011 21:03:30 +0000]
Use <Enter> in stead of Ctrl+. for peeking last move
I commented out the explicit detection of the Ctrl key, as this
is not needed when there are no 'unnatural' Ctrl keystrokes used
for binding.
H.G. Muller [Wed, 28 Dec 2011 18:37:49 +0000]
Next try for menu-bar sizing
This time request the width needed to just fit everything, and then start
shaving off pixels from the currently largest until the entire thing fits.
H.G. Muller [Wed, 28 Dec 2011 14:17:49 +0000]
Clip texts on menu bar
The width of the items on the main menu bar is restricted so the bar
will never exceed board width.
H.G. Muller [Wed, 28 Dec 2011 13:01:53 +0000]
Fix format in temporary timing printf
H.G. Muller [Wed, 28 Dec 2011 12:38:59 +0000]
Don't test drops as mate evasions in variant seirawan
H.G. Muller [Wed, 28 Dec 2011 12:36:23 +0000]
Fix ICS castling rights
Copying the castling rights together with CopyBoard seems to have
broken handling of ICS rights, where ParseBoard12 prepares a board
in a local variable, an copies it before parsing the rights.
H.G. Muller [Wed, 28 Dec 2011 12:35:10 +0000]
Fix initial holdings ICS seirawan games
H.G. Muller [Tue, 27 Dec 2011 17:31:05 +0000]
Fix sending of S-Chess gating moves to ICS
Normal moves did not get the gating suffix sent.
H.G. Muller [Tue, 27 Dec 2011 16:56:07 +0000]
Fix menu grayout after illegal move
TheThinkingEnables were not reset to user state after the engine rejected
the entered move as illegal.
H.G. Muller [Tue, 27 Dec 2011 12:26:36 +0000]
Allow setting of holdings with edit command
For the benefit of Fairy-Max' Seirawan Chess implementation, the edit command
no also sends holdings contents (if the engine sent feature xedit=1), encoded
as pieceType + '@' + holdingsCount (if the count is non-zero).
H.G. Muller [Sat, 24 Dec 2011 16:54:16 +0000]
Fix out-of-bounds access in check test
Thepath to make the check test work with drops had broken the test
after null move (both have rf<0), which led to corruption of the high
word of the black clock.
H.G. Muller [Sat, 24 Dec 2011 16:51:22 +0000]
Fix legality of Spartan promotion to king
In the check test promotion to King is only allowed if there are not
yet 2 kings.
H.G. Muller [Wed, 21 Dec 2011 21:17:01 +0000]
Fix switching back from mono-mode XB
Suppressing unnecesary X-server calls in InitDrawingSizes had broken
switching back from monoMode, because the animVars have to be recreated
for that, and this was only done when the variant changed.
H.G. Muller [Wed, 21 Dec 2011 21:09:02 +0000]
Fix showTargetSquares in mono-mode XB
Make the marker dots black (captures) and white, and draw a circle
in the opposite color around them in monoMode.
H.G. Muller [Wed, 21 Dec 2011 21:00:26 +0000]
Fix arrow highlighting in mono-mode XB
Draw a line around it in darkSquare color in monoMode.
H.G. Muller [Wed, 21 Dec 2011 16:48:33 +0000]
Fix alignment of generic browse button XBoard
The width ofthe browse button is now read back after creating it,
and subtracted from the preceding text edit.
H.G. Muller [Wed, 21 Dec 2011 13:41:31 +0000]
Add -afterTourney option
Only the instance pinting the tourney result will execute this.
Byrial Jensen [Thu, 22 Dec 2011 20:01:43 +0000]
Fix buffer possible overflow when writings tags
PGNTagsStatic() could overflow its buffer and is removed. PGNTags() do the work instead of calling it.
It starts by calculation the required buffer size and then allocate the buffer.
PrintPGNTags() now prints directly to the file without having a buffer.
Byrial Jensen [Thu, 22 Dec 2011 14:01:31 +0000]
One more string marked for translation
And it is moved inside the if statement that uses it.
Byrial Jensen [Thu, 22 Dec 2011 13:30:08 +0000]
Fix checking of return value from snprintf()
snprintf() returns the needed space excluding the trailing 0 byte, so
it has truncated if the returned valued is greater than or EQUAL TO the buffersize
Byrial Jensen [Mon, 19 Dec 2011 15:49:31 +0000]
Fix unportable memory initialisation
Memory sat to zero by calloc() cannot safely be assumed to have the pointer value NULL
Byrial Jensen [Mon, 19 Dec 2011 12:16:58 +0000]
Add 2 strings for translation
Byrial Jensen [Mon, 19 Dec 2011 10:25:11 +0000]
Remove the last 2 compile warnings in gamelist.h
Byrial Jensen [Mon, 19 Dec 2011 10:17:48 +0000]
Add #include "moves.h" to gamelist.c for def. of CopyBoard()
Byrial Jensen [Mon, 19 Dec 2011 10:11:34 +0000]
Definition of TimeMark moved from 3 c files to backend.h
Byrial Jensen [Mon, 19 Dec 2011 00:21:46 +0000]
Transfer a pointer to the promoChar from PromotionPopUp() to PromotionCallback(). Fixes #34980
Byrial Jensen [Sun, 18 Dec 2011 16:24:07 +0000]
Duh! Initialise the argument to sscanf() inside the loop, so it always gets a known value when sscanf() fails.
Byrial Jensen [Sun, 18 Dec 2011 16:18:12 +0000]
Give numeric options the value 0 if a non-numeric text is entered (one more place). Before the value ended up undefined.
Byrial Jensen [Sun, 18 Dec 2011 16:08:46 +0000]
Give numeric options the value 0 if a non-numeric text is entered. Before the value ended up undefined.
Byrial Jensen [Sun, 18 Dec 2011 14:41:46 +0000]
Fix possible crash on 64-bit systems when copying game or position
The two convertproc's for X selections caused reads out of bounds on 64-bit systems.
I hope that this is the right solution. I am not experienced with X stuff, but it
follows that I have seen in other programs, testing shows that copying still works,
and the reading out of bounds have disappearinged with this patch.
Byrial Jensen [Sun, 18 Dec 2011 12:26:20 +0000]
Fix a possible crash in the file browser
If the OK button was selected in the file browser when no file was selected
there was a read out of bounds which could crash xboard
Byrial Jensen [Sat, 17 Dec 2011 21:54:34 +0000]
Fix a memory leak in Sound Options
Byrial Jensen [Fri, 16 Dec 2011 01:57:20 +0000]
Fix crash when selecting user soundfile due to free() of not malloc()'ed memory
Byrial Jensen [Fri, 16 Dec 2011 01:32:37 +0000]
Make GenericPopUp() more readable by using more named flags instead of numerals
Defines the flags SAME_ROW (value 1) and NO_OK (value 2) for use with buttons and endmarks.
There should no functional change.
Also add a code comment where a condition depends on an uninitialised value. There is no direct harm, as both
branches do the same (that is nothing) when the value is uninitialised.
Byrial Jensen [Thu, 15 Dec 2011 01:51:36 +0000]
Add NO_GETTEXT flag for combobox. Fix bug #34991
Define NO_GETTEXT flag to avoid calling gettext() for comboboxes, and define COMBO_CALLBACK
flag to call comboCallback() when an item is selected in a combobox (no new code for this,
just a symbolic value instead of a number). The flags are used for the min field of struct Option.
NO_GETTEXT is used for the Select engine combobixes in the Match Options and Load engine windows.
Arun Persaud [Wed, 14 Dec 2011 03:48:37 +0000]
only translate entries in CreateComboPopup if strlen>0; fixes #34991
Byrial Jensen [Tue, 13 Dec 2011 03:06:26 +0000]
fix for repeating key issue, with this allissues this bug should be closed; fixes #35000
Arun Persaud [Tue, 13 Dec 2011 02:45:05 +0000]
also don't translate selection in ComboSelect; fixes #34991
Arun Persaud [Tue, 13 Dec 2011 02:40:23 +0000]
make entries in CreateComboPopup not translateable; fixes #34991
Arun Persaud [Sun, 11 Dec 2011 00:06:47 +0000]
fix translation for engine list; fixes #34991
* click on browse button should be recognized in translated versions
* width of button should auto-scale
Arun Persaud [Sat, 10 Dec 2011 19:04:17 +0000]
change keybindings that don't use ctrl, make MoveTypeInProc ctrl aware; fixes #35000
two keybindings were using keys without modifiers, adjusted these to use the ctrl key.
Furthermore when typing in moves we need to check if ctrl was pressed and ignore those inputs.
Also added documentation for these keybindings.
Arun Persaud [Sat, 10 Dec 2011 18:51:18 +0000]
replaced unicode character for "'" in xboard.texi
Arun Persaud [Sat, 10 Dec 2011 18:08:48 +0000]
removed Iconify function. Should be handled by the window manager.
Arun Persaud [Fri, 9 Dec 2011 04:53:13 +0000]
marked an error messages for translation
Arun Persaud [Fri, 9 Dec 2011 04:33:29 +0000]
translation: updated uk.po
Arun Persaud [Sun, 4 Dec 2011 01:52:23 +0000]
fixed size of XBoard icon to 48x48
the icon gets installed in the 48x48 directory, but was >200 pixel wide. This gave a warning during rpm creation.
Arun Persaud [Sat, 3 Dec 2011 16:07:32 +0000]
updated pot file
marked a lot of new strings for translation
Arun Persaud [Sat, 3 Dec 2011 16:06:42 +0000]
added new files to po/POTFILES.in
Arun Persaud [Sat, 3 Dec 2011 06:13:36 +0000]
marked more strings for translation
Arun Persaud [Sat, 3 Dec 2011 04:08:01 +0000]
translation: added danish translation
H.G. Muller [Thu, 1 Dec 2011 17:45:55 +0000]
Change encoding of seirawan ICS gating-castlings
In stead of using upper/lower-case promoChar, the ICS now uses
RxK notation, like WinBoard writes in SAN, for better consistency.
H.G. Muller [Wed, 30 Nov 2011 14:38:21 +0000]
Put promo-suffix on ICS move in variant seirawan castlings
The distinction upper-case / lowercase determines gating at R / K
H.G. Muller [Mon, 28 Nov 2011 10:56:18 +0000]
Refrain from making unnecessary resize X request
The window resizing code in InitDrawingSizes is suppressed when no
change is needed. Similarly, changing piece bitmaps is suppressed when
we stay in the same variant (and InitDrawingSizes is called e.g. because
of chaging lineGap through the Board dialog).
H.G. Muller [Sun, 27 Nov 2011 21:27:00 +0000]
Fix parsing of O-O castling in variant janus
The new parser did not realize it meant e1i1 rather than wild e1h1.
H.G. Muller [Sat, 26 Nov 2011 21:28:23 +0000]
Show 50-move counter also when observing ICS games
To not cheat 50-move display was suppressed in ICS mode,
but for observing a game this made no sense.
H.G. Muller [Sat, 26 Nov 2011 21:22:07 +0000]
Ignore ICS game starts when already in game
The advance switching of the variant on game-start messages was
disruptive for users with gin=1, which also sends such messages
for other games than your own. For now fixed by only reacting on
them when idle (detected by invalid game number).
H.G. Muller [Fri, 11 Nov 2011 17:16:19 +0000]
Fix WinBoard clock-click bug
Clicking on the clock in WinBoard also called the LeftClick routine
for handling clicks on the board. This led to the from-square being set
to some inalid value, so that the next genuine board click was interpreted
as a to-click, with undesired effects, especially with legality testing off
or in EditPosition mode, where weird things are accepted.
H.G. Muller [Sun, 6 Nov 2011 16:20:01 +0000]
Add feature-override options
A few (dangerous) options are added to allow a user to override
engine features, or change their defaults, by supplying a string
with feature commands (e.g. "sigint=0") which tricks XBoard into
thinking the engine sent that. There is a -featureDefaults which is
processed before the engine features, and -first/secondFeatures
which is parsed just before engine initialization.
This goes horribly wrong when the user wouldtry silly things like
including 'option' or 'done' features!
Arun Persaud [Sat, 5 Nov 2011 19:32:39 +0000]
translation: updated uk.po
H.G. Muller [Fri, 4 Nov 2011 20:58:39 +0000]
Fix handling of -secondOptions option
The -firstOptions and -secondOptions settigs were not swapped when
-singleEngieList was true, so the second engine's options would never
be set in that case, but used for the first engine.
H.G. Muller [Fri, 4 Nov 2011 20:55:21 +0000]
Accept setup command in variant fairy even with legality testing on
Variant fairy does not really have a defined opening position, but lots
of pieces defined, so we might want to play with legality checking on,
but still rely on the engine for the opening position
H.G. Muller [Fri, 4 Nov 2011 20:52:20 +0000]
Set pieceToCharTable by setup command even when ignoring FEN
When the user starts from a set-up position, the egines default
openingposition has to be ignored, but the pieceToCharTable would
still be relevant.
H.G. Muller [Fri, 4 Nov 2011 20:48:24 +0000]
Change default sweep-promotion choicein queenless variants
The initial scanning of the sweep piece until a defined piece is found
is now in the increasing direction (still starting at Queen), so that
the fairy pieces are suggested before R, B and N.
H.G. Muller [Thu, 3 Nov 2011 15:38:57 +0000]
Clear board markers when moving to other position
Now the markers from -showTargetSquares would stay on after a first click
for the benefit of a click-click move, they would also stay on when not
finishing the move, but operating the < > buttons in stead to call up
other positions. ForwardInner and BackwardInner now clear the markers,
like they also cleared highlights.
Arun Persaud [Wed, 2 Nov 2011 01:30:22 +0000]
updated Changelog, NEWS, etc.
H.G. Muller [Tue, 25 Oct 2011 13:32:27 +0000]
Fix two warnings
H.G. Muller [Mon, 24 Oct 2011 18:00:28 +0000]
Don't adjust clock on right-click in EditGame mode WB
This was a change that was already done for the left-clicks, but somehow
never made it togit for the right-clicks
H.G. Muller [Mon, 24 Oct 2011 17:50:25 +0000]
Change chase message in .lng files
H.G. Muller [Mon, 24 Oct 2011 17:31:08 +0000]
Let perpetual-chase message mention square
In stead of a boolean, PerpetualChase now returns the square the chased
piece ends on (encoded as an int), and on adjudication it will be printed.
H.G. Muller [Mon, 24 Oct 2011 17:26:02 +0000]
Add mechanism to translate variable messages in WinBoard
A message prefixed with % in the lng file will be considered a match
if it matches the start of the text to be printed, and the remaining
part of the latter will remain untranslated. This was needed to allow
translation of the perpetual change message, now it indicates the square
of the chased piece.
H.G. Muller [Mon, 24 Oct 2011 17:20:13 +0000]
Use other interpretation of Asia rules for chase detection
The detection of perpetual chases now ignores pre-existing checks.
H.G. Muller [Wed, 12 Oct 2011 15:28:48 +0000]
Fix crash on loading garbage game file
The code to cache games was not resistant to moves before a valid
game start, or a game filewithout any games at all.
H.G. Muller [Sat, 8 Oct 2011 18:43:52 +0000]
Incorporate variant type in book hash key
This prevents booksforone variant being used for another, and allows
multi-variant books.
H.G. Muller [Fri, 7 Oct 2011 13:41:44 +0000]
Update language.txt file
H.G. Muller [Fri, 7 Oct 2011 13:34:01 +0000]
Update Dutch lng file
H.G. Muller [Fri, 7 Oct 2011 13:21:53 +0000]
Fix Load Options dialog WB
Defined fastkeys; reordered elements so that fastkeys focus edit they
are intended for. Changed some of the more obscure texts. Corrected
list of transatble dialog items, adding a few missing ones.
H.G. Muller [Tue, 13 Sep 2011 18:01:42 +0000]
Fix some warnings
Prototypes were added, ormoved from backend.c to backend.h.
H.G. Muller [Fri, 26 Aug 2011 10:44:08 +0000]
Put 'Load Next' button back in WB Game List
The '>' button for loading the next (filtered) game is re-instated in the
WinBoard GameList. The main window has now accelerator keys Ctrl+Up and
Ctrl+Down for loading the previous and next filtered game.
H.G. Muller [Fri, 26 Aug 2011 10:31:59 +0000]
Speed up position search and consider side to move
The position search is made to pay attention to the side to move,
which produces a speedup, because we only have to compare half the
game positions when looking for an exact position match. An addition
we now keep track of the total number of pieces, and abandon a game when
it drops below the number of pieces in the position we seek.
H.G. Muller [Sun, 21 Aug 2011 21:16:15 +0000]
Dynamically allocate move cache
A small statically declared cache good for 250k moves (~3200 games)
will be expanded in steps of a factor 8 when it overflows.
H.G. Muller [Thu, 18 Aug 2011 16:40:38 +0000]
Translate search strings
H.G. Muller [Wed, 17 Aug 2011 20:55:21 +0000]
Implement flipped search
H.G. Muller [Tue, 16 Aug 2011 13:29:03 +0000]
Debug position search cache
H.G. Muller [Mon, 15 Aug 2011 16:44:37 +0000]
profile
H.G. Muller [Thu, 18 Aug 2011 16:01:54 +0000]
Translate search-mode strings
H.G. Muller [Mon, 15 Aug 2011 14:59:39 +0000]
Quickscan
H.G. Muller [Sun, 23 Oct 2011 14:04:00 +0000]
Fix duplicate loading of second engine in tourneys
To decide if new engines should be loaded, it was tested if first.pr
equalled NoProc, assuming that ReserveGame would have left the engine
loaded if the next game would need the same engines. But a reuse=0 engine
could have caused termination of the first engine process anyway, while
the second would still be alive. So unconditionally starting of the second
engine would cause redundant engine processes to abound.
Now we only start new engine processes if both engine processes are dead.
H.G. Muller [Sun, 23 Oct 2011 13:53:32 +0000]
Fix PV walking with -fSAN
The SAN options had broken the PV walking, because the shelving of the
walked PV to create space for the conversion to SAN of an incoming PV
would not be properly undone, but would add the walked PV to the game.
H.G. Muller [Thu, 20 Oct 2011 10:39:10 +0000]
Refine clock adjusting
Adjusting the clocks by shift-clicking them is now only allowed with
autoCallFlag off, and an error-popup results when you do it otherwise.
Also, swtching to Edit Game mode won't reset the clocks to the stored
value anymore when you have just adjusted it.
H.G. Muller [Wed, 12 Oct 2011 15:43:33 +0000]
Fix crash on adding items near book end
When Edit Book would add so many entries near the end of an opening
book that the end of the added info would surpass the old end of the
file, the copying of the tail got stuck in an infinite loop, extending
the file without limit with repeating info.
H.G. Muller [Wed, 12 Oct 2011 15:41:18 +0000]
Print message on wrong use of Clone Tourney
The user is urged to first provide the name of an existing tourney file
when he presses the button without one. The button is also renamed.
H.G. Muller [Wed, 12 Oct 2011 15:38:33 +0000]
Fix invalid combobox entry WB
A combobox label that was not in the list (because the user typed
it, rather than selecting one) would cause a crash.
H.G. Muller [Wed, 12 Oct 2011 15:23:57 +0000]
Fix crash on loading garbage game file
XBoard crashed when a game file contained a PGN game result before
any valid game start, because data would be written in a game-list
node that did not exist yet. This would occur frequently when garage
was read; basically any asterisk in the data would do it.
H.G. Muller [Tue, 11 Oct 2011 21:31:01 +0000]
Add control to set -discourageOwnBooks WB
Arun Persaud [Wed, 12 Oct 2011 03:53:52 +0000]
only require 0.17 of gettext
This seems to solve many build issues with older distrubtions and doesn't seem to be a problem with newer ones.
H.G. Muller [Tue, 11 Oct 2011 21:31:01 +0000]
Add option -discourageOwnBooks
This boolean option determines the default setting of the hasOwnBook
option before a tourney game starts. By setting it, the hasOwnBook
option is cleared, which would enable use of the GUI book, like the
engine was installedwith the /firstXBook option. An explicit option
on the engine install line can still overrule this, though.
A control to set this option has been added in the XBoard Match dialog,
and it is saved in the tourney file to force consistency.